I know this has been debated since 2006 but I thought I'd offer my opinion for what whatever that's worth. I owned an e90 330i for about a year and a half. Since my friend has had extensive seat time behind the wheel of the e46 330i, we thought it would be cool to make a video sharing both our experiences.
The first video predominantly outlines the e90 and the second highlights the e46.
Hope you enjoy them, and any feedback is appreciated! https://www.youtube.com/watch?v=U6VIqlyiwek