As far as I know the HPFP issue is really on a problem on the twin turbo models, especially the n54 twin turbo engine. BMW knows its a serious problem and offers a 10 year 120,000 mile warranty on the HPFP for the n54 twin turbo.
If its a serious problem with the naturally aspirated 08-11 3 series then I'm sure they offer the same 10 year 120,000 mile warranty on it.
My fuel pump first failed around 35k miles so I took it in to have it replaced the next day and it took a few hours and I got a free car wash too! Anyways, my 535i has about 55k miles now and still has the same replacement pump. Although, I've heard stories of people having 3-4 replacements by 60k miles.
The 335i is a great car if you're looking for good performance. It handles well, has just over 300hp and 300tq (BMW quotes 300hp, but the n54 twin turbo engine has been proven to produce around 320 hp and tq), and can easily be modded to 400+hp.
I love my 535i which has the same n54 twin turbo engine as the e90/92 335i. The engine has won 5 "International Engine of the Year" awards, as well as 3 awards for "Wards 10 Best Engines". Keep in mind, the n54 twin turbo engine will be more costly to maintain than a N/A (naturally aspirated) 3 series engine.
Another common problem with BMW's in general is their water pumps. The water pump on my 535i broke at 50k miles and I've read many stories about them breaking before 75k miles, which is a very short life for a water pump. For the dealership to do the repair, its about $1000 (depending on year, model, etc) so its quite a costly deal unless you DIY.