Tokico struts and shocks are quite good (HD's not so good, illuminas good) on Japanese applications (had them on an integra and crx). But, I would not use them on the heavier German cars. I've heard of them failing on Bimmers.
I have the Koni sports and love them, and Bilsteins on my volvo wagon--no problems. Konis are better tho in my experience. H&R is the best for springs, unless you're doing Dinan. I love my Dinan stage 1 setup.
98 328i, black/black, manual, canadian sport pkg, ECIS intake, koni sport adj's, dinan springs, oe/oem clears.
Considering: tms shark,M 17" wheels, larger sway bars.